Tim Armstrong has posted comments on this change. Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file ......................................................................
Patch Set 4: (2 comments) Only minor style comments remaining. http://gerrit.cloudera.org:8080/#/c/6522/4/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: Line 70: if new_vector.get_value('table_format').file_format == 'kudu': We can make this more concise: in ('kudu, 'hbase') Line 74: self.run_test_case('QueryTest/rows-read', new_vector) Might as well make this a separate test method, e.g. test_rows_read(). Or actually that seems very specific. Maybe rename to something like test_hdfs_scanner_profile/hdfs-scanner-profile. -- To view, visit http://gerrit.cloudera.org:8080/6522 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie42c97a36e46172884cc497aa645036c2c11f541 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
