Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5172: Buffer overrun for Snappy decompression ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6625/2/be/src/util/decompress.cc File be/src/util/decompress.cc: PS2, Line 467: return Status(TErrorCode::SNAPPY_DECOMPRESS_DECOMPRESS_SIZE_INCORRECT); nit: Wondering if this is the right error message to return in SnappyBlockDecompress? Should we have an equivalent error message for SnappyBlock? We do differentiate between Snappy and SnappyBlock error codes here: https://github.com/apache/incubator-impala/blob/6242478d0c06c8ee92310632a4903e56e50fe40a/common/thrift/generate_error_codes.py#L82-L95 -- To view, visit http://gerrit.cloudera.org:8080/6625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45b75f61e8c0ae85f9add5b13ac2b161a803d2ba Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
