Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3040: Fix test_caching_ddl test ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6603/2/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: Line 311: max_num_stabilization_attempts = 3 > This is a little strange to me. If the num_requests keep changing, then int Done Line 311: max_num_stabilization_attempts = 3 > So, you want to exit when no change is detected? I think you'll exit premat Done Line 311: max_num_stabilization_attempts = 3 > Actually having a 10s timeout still seems like a good idea Done Line 324: num_stabilization_attempts = num_stabilization_attempts + 1 > I am not sure. Shouldn't we put an upper bound here? Done -- To view, visit http://gerrit.cloudera.org:8080/6603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ec4ba5dfae6e90a2bb76e22c93909b05bd78fa4 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
