Dan Hecht has posted comments on this change.

Change subject: IMPALA-2800: make memory maintenance less aggressive
......................................................................


Patch Set 4:

As we talked about in person, it'd be good to figure out whether the 
GcTcmalloc() is coming into play.

Also, if we do need to keep this code, it seems like the rate of 256MB / 10 
seconds is too slow to be meaningful (1.5 hours to release 128 GB). So it seems 
we should either remove this altogether if it's not needed, or speed it up if 
it is.

-- 
To view, visit http://gerrit.cloudera.org:8080/6626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f822b294ab253d6f2828fc52f353aecaaf9b701
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: anujphadke <[email protected]>
Gerrit-HasComments: No

Reply via email to