Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/6664
Change subject: IMPALA-4548: BlockingJoinNode should wait for async build thread ...................................................................... IMPALA-4548: BlockingJoinNode should wait for async build thread This is a minor clean up for the handling of the async build thread in BlockingJoinNode. In particular, the main thread used to block on the promise passed to the async build thread and won't proceed until the status is set. Async build thread relies on the fragile assumption that no other states (e.g. runtime state object) will be accessed once the promise is set. This has proven to be fragile with the use-after-free bug in IMPALA-4532. This change removes the reliance on fragile assumption by making the main thread join the async build thread before proceeding. Change-Id: I33b07d60426cde61922b05c969ef09453ac0f342 --- M be/src/exec/blocking-join-node.cc M be/src/exec/blocking-join-node.h 2 files changed, 21 insertions(+), 28 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/6664/1 -- To view, visit http://gerrit.cloudera.org:8080/6664 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33b07d60426cde61922b05c969ef09453ac0f342 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]>
