Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5145 : Do not constant fold null in CastExprs ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6663/1//COMMIT_MSG Commit Message: PS1, Line 9: cuases typo. http://gerrit.cloudera.org:8080/#/c/6663/1/fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java File fe/src/main/java/org/apache/impala/rewrite/FoldConstantsRule.java: Line 20: nit: remove extra line. http://gerrit.cloudera.org:8080/#/c/6663/1/testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test File testdata/workloads/functional-query/queries/QueryTest/create-table-as-select.test: Line 187: # IMPALA-5145: Do not constant fold null in CastExprs > extra space fold 'null' Alex, is it cleaner to add it in AnalyzeDDLTest#TestCreateTableAsSelect() ? -- To view, visit http://gerrit.cloudera.org:8080/6663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7aa1ab7f53a9dcc7560ded321a9d1e1ee2d18e3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
