Tim Armstrong has posted comments on this change. Change subject: IMPALA-3748: minimum buffer requirements in planner ......................................................................
Patch Set 17: Code-Review+2 (3 comments) Rebase http://gerrit.cloudera.org:8080/#/c/5847/16/fe/src/main/java/org/apache/impala/planner/PipelinedPlanNodeSet.java File fe/src/main/java/org/apache/impala/planner/PipelinedPlanNodeSet.java: Line 126: Preconditions.checkState(sinkProfile.getMemEstimateBytes() >= 0); > this is already done in finalize() Thanks for catching this, didn't finish moving it. This actually masked a bug where we didn't compute resource profiles for build sinks when generating the parallel plans. http://gerrit.cloudera.org:8080/#/c/5847/16/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: Line 151: * Finalize plan tree and create stream sink, if needed. > update comment Done http://gerrit.cloudera.org:8080/#/c/5847/16/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: Line 621: * Compute resources consumed when executing this PlanNode, initializing > i'd simply mention the member var explicitly Done -- To view, visit http://gerrit.cloudera.org:8080/5847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e358182bcf2bc5fe5c73883eb97878735b12d37 Gerrit-PatchSet: 17 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
