Henry Robinson has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6535/6/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS6, Line 408: // TODO: rename this metric > meaning nothing depends on this name at the moment? Correct. PS6, Line 885: TODO: do we need this error propagation path, in addition to the status report : // we'll get anyway? > when a fragment instance fails it reports an error status right away. It reports by making an RPC, which can be delayed for any one of a number of reasons. I don't quite see what the TODO is asking - is it whether we need to return an error from GetNext() if coord_sink_->GetNext() failed? -- To view, visit http://gerrit.cloudera.org:8080/6535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20769e420711737b6b385c744cef4851cee3facd Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
