Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5217: KuduTableSink checks null constraints incorrectly ......................................................................
Patch Set 1: Code-Review+2 (1 comment) nice catch http://gerrit.cloudera.org:8080/#/c/6670/1//COMMIT_MSG Commit Message: PS1, Line 8: : KuduTableSink uses the referenced_columns map to translate between the index into the : output exprs 'j' and the index into columns in the Kudu table 'col', but we incorrectly : use 'j' when calling into the Kudu table schema to check the nullability of columns. nit: wrap msg please -- To view, visit http://gerrit.cloudera.org:8080/6670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed458278f135288a821570939de8ee294183df2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
