Dan Hecht has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/6610/1/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: Line 344: // Some exec nodes rely on the slot-order in the tuple descriptor to correspond to the > The agg node also relies on this: Hmm, i see. http://gerrit.cloudera.org:8080/#/c/6610/4/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: Line 346: // originals. i think a comment like this would be better at the slots_ field definition. something like: /// Slots are in the same order as the expressions that materialize them. See Tuple::MaterializeExprs(). Line 360: std::sort(other_slots.begin(), other_slots.end(), SlotComparator()); how about using the same sort technique we use in TupleDescriptor::GetLlvmStruct()? you could even factor that into a private TupleDescriptor::GetSortedSlots() subroutine. -- To view, visit http://gerrit.cloudera.org:8080/6610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I426ad244678dbfe517262dfb7bbf4adc0247a35e Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
