Henry Robinson has posted comments on this change. Change subject: IMPALA-5174: Add hidden flags to gflags (2.2.0-p1) ......................................................................
Patch Set 2: (2 comments) Re: upstreaming, it seems like gflags is governed mostly by what Google's needs are internally. It would be worthwhile to try, but not to gate this patch on doing so. http://gerrit.cloudera.org:8080/#/c/6672/1/source/gflags/gflags-2.2.0-patches/0001-Allow-hidden-flags-e.g.-DEFINE_int32_hidden.patch File source/gflags/gflags-2.2.0-patches/0001-Allow-hidden-flags-e.g.-DEFINE_int32_hidden.patch: Line 5: > we should have something to explain this since this isn't tracking an upstr Done PS1, Line 191: + DEFINE_VARIABLE(GFLAGS_NAMESPACE::int32, I, name, val, txt, true) : > missing DEFINE_uint32_hidden Done -- To view, visit http://gerrit.cloudera.org:8080/6672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d718bac3dbf548cdaefc70f8f497bbebe30da6 Gerrit-PatchSet: 2 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
