Jim Apple has submitted this change and it was merged. Change subject: IMPALA-5031: Remove undefined behavior: left shift of large signed ......................................................................
IMPALA-5031: Remove undefined behavior: left shift of large signed Shifting large positive signed values is undefined when the result is not "representable in the corresponding unsigned type of the result type". Left shift of unsigned values is always defined. See the C++14 standard, section 5.8 [expr.shift], paragraph 2. Change-Id: I748697cf503e9e717a6e95250c2cbbf031c6352d Reviewed-on: http://gerrit.cloudera.org:8080/6528 Tested-by: Impala Public Jenkins Reviewed-by: Jim Apple <[email protected]> --- M be/src/exprs/bit-byte-functions-ir.cc 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Jim Apple: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I748697cf503e9e717a6e95250c2cbbf031c6352d Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
