Michael Ho has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase agg ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6724/4/be/src/testutil/test-udas.cc File be/src/testutil/test-udas.cc: PS4, Line 59: nctionContex > why "Intermediate"? THis validates arg and return type as well. Renamed to ValidateFunctionContext* -- To view, visit http://gerrit.cloudera.org:8080/6724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I158303b20d1afdff23c67f3338b9c4af2ad80691 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
