Zach Amsden has posted comments on this change.
Change subject: IMPALA-5003: Constant propagation in scan conjuncts
......................................................................
Patch Set 23:
So this tripped up on an functional.alltypes_datasource test, and the first
failure was obvious, but now there is a new failure mode which isn't obvious at
all, and unclear how it relates to this change:
[localhost:21000] > select string_col from alltypes_datasource
where string_col = 'VALIDATE_PREDICATES##id NOT_DISTINCT 1 && id DISTINCT_FROM
1 && id NOT_DISTINCT 1'
and 1 <=> id and 1 IS DISTINCT FROM id and 1 IS NOT DISTINCT FROM id;
Query: select string_col from alltypes_datasource
where string_col = 'VALIDATE_PREDICATES##id NOT_DISTINCT 1 && id DISTINCT_FROM
1 && id NOT_DISTINCT 1'
and 1 <=> id and 1 IS DISTINCT FROM id and 1 IS NOT DISTINCT FROM id
Query submitted at: 2017-04-26 17:20:43 (Coordinator: http://impala-dev:25000)
ERROR: InternalException: Data source DataSource{name=alltypesdatasource,
location=hdfs://localhost:20500/test-warehouse/data-sources/test-data-source.jar,
className=org.apache.impala.extdatasource.AllTypesDataSource, apiVersion=V1}
returned an error from prepare(): Error in data source
(path=/tmp/test-data-source.29405.0.jar,
class=org.apache.impala.extdatasource.AllTypesDataSource, version=V1)
prepare(): No error message returned by data source. Check the impalad log for
more information.
--
To view, visit http://gerrit.cloudera.org:8080/6389
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79750a8edb945effee2a519fa3b8192b77042cb4
Gerrit-PatchSet: 23
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zams...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com>
Gerrit-HasComments: No
