Michael Ho has posted comments on this change. Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5198/3/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: PS3, Line 136: buf_len != 0 Not needed anymore as zero length allocation should not return NULL. This should be added to the DCHECK below to become: DCHECK(buf_len > 0 && !ctx->impl()->state()->GetQueryStatus().ok()); -- To view, visit http://gerrit.cloudera.org:8080/5198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5b9349dd08556eba5cfedc8c0063cc59f5be03 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
