Michael Ho has posted comments on this change.

Change subject: IMPALA-5261: Heap use-after-free in HdfsSequenceTableWriter
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

I assumed you have verified the fix with ASAN build, right ?

http://gerrit.cloudera.org:8080/#/c/6762/1/be/src/exec/hdfs-sequence-table-writer.cc
File be/src/exec/hdfs-sequence-table-writer.cc:

Line 306:     value_length = text.size();
DCHECK_EQ(value_length, row_buf_.Size());


-- 
To view, visit http://gerrit.cloudera.org:8080/6762
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id339247f892710529d8ad56dd1e98eadbf32900b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-HasComments: Yes

Reply via email to