Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5262: test_analytic_order_by_random fails with assert ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6775/1/tests/query_test/test_sort.py File tests/query_test/test_sort.py: Line 189 > Do we have any end-to-end tests that exercise non-deterministic exprs in an Do you have any suggestions? Its hard to check the output in a reliable way unless we're able to have the random() values returned so that we can check that their order is correct, but I don't know of any way to do that (other than use an inline view, which doesn't work, see IMPALA-5270) We can run the query without checking its output just to ensure that it doesn't crash, though the crash that was happening here was rare so that doesn't give us much coverage. We could fix that by adding it to the query generator. I also haven't actually repro-ed this, so I could also investigate why its actually failing and it may be something related to local filesystem that could get fixed, but the entire premise of the test if faulty and its likely to just continue to be flaky (e.g. if IMPALA-660 get addressed). -- To view, visit http://gerrit.cloudera.org:8080/6775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1ba8154c2b6a8d508916d85391b95885ef915a9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
