Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4866: Hash join node does not apply limits correctly ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6778/1//COMMIT_MSG Commit Message: PS1, Line 11: exhcnage typo http://gerrit.cloudera.org:8080/#/c/6778/1/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: PS1, Line 580: > >= ? Line 581: out_batch->CommitRows(limit_ - num_rows_returned_); I think you need to update num_rows_returned_ as well http://gerrit.cloudera.org:8080/#/c/6778/1/tests/common/test_dimensions.py File tests/common/test_dimensions.py: PS1, Line 114: # Don't run with NUM_NODES=1 due to IMPALA-561 : # ALL_CLUSTER_SIZES = [0, 1] update comment -- To view, visit http://gerrit.cloudera.org:8080/6778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I414124f8bb6f8b2af2df468e1c23418d05a0e29f Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
