Dan Hecht has posted comments on this change. Change subject: Experiment: glibc strncmp/memcmp appears much faster than SSE4.2 ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6768/1//COMMIT_MSG Commit Message: PS1, Line 17: memcmp is sse4.1-based > I don't understand - what use of memcpy? I was hoping only to replace the / Oops, yeah cmp. There aren't many direct callers but the caller callers are used in various places (and in and out of the IR), and over various data sizes/patterns. Which is why it'd be nice to verify with the benchmarks that everything's good. -- To view, visit http://gerrit.cloudera.org:8080/6768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4786a4a75fdaffedd6e17cf076b5368ba4b4e3e Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-HasComments: Yes
