Dan Hecht has posted comments on this change.
Change subject: IMPALA-5246: UDF's Close() should handle Expr's preparation
failure
......................................................................
Patch Set 1:
Free() already has a null check. What am I missing?
void FunctionContext::Free(uint8_t* buffer) noexcept {
assert(!impl_->closed_);
if (buffer == NULL) return;
--
To view, visit http://gerrit.cloudera.org:8080/6757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-HasComments: No
