Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause ......................................................................
Patch Set 17: (7 comments) http://gerrit.cloudera.org:8080/#/c/6495/17//COMMIT_MSG Commit Message: PS17, Line 30: SORT BY columns supersede the sortby() hint, which we will remove in a : subsequent change (IMPALA-5144). Mention what happens if both are used (e.g. union the columns or something else) http://gerrit.cloudera.org:8080/#/c/6495/17/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: PS17, Line 152: Returns a list of positions of : * the sort by columns within the table's list of columns This function doesn't return anything. PS17, Line 183: // ALTER TABLE SET is not supported on HBase tables altogether. : Preconditions.checkState(!(table instanceof HBaseTable)); This check doesn't belong here. Maybe move it to the analyze() function? http://gerrit.cloudera.org:8080/#/c/6495/17/fe/src/main/java/org/apache/impala/analysis/AlterTableSortByColumnsStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSortByColumnsStmt.java: PS17, Line 61: HashMap nit: Map PS17, Line 87: a nit: an http://gerrit.cloudera.org:8080/#/c/6495/17/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java: PS17, Line 138: Mention what happens if both are used (i.e. sort.by.column and sortby() hint). http://gerrit.cloudera.org:8080/#/c/6495/17/testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test File testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test: PS17, Line 1: # Add one or more tests where the sortby hint is used in conjunction with sort by clause, if you don't already have one. -- To view, visit http://gerrit.cloudera.org:8080/6495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75 Gerrit-PatchSet: 17 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
