Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5246: MemTestClose() should handle Expr's preparation failure ......................................................................
IMPALA-5246: MemTestClose() should handle Expr's preparation failure UDF may fail to initialize due exceeding memory limit or other reasons. In which case, its Prepare() function may not have been called and its thread local state may not be initialized. MemTestClose() in test-udf.cc made the wrong assumption that the thread local states are always initialized. This may lead to de-referencing null pointer in Close(). This change fixes this issue by checking the thread local state is not null and returns early if so. Also sets the fragment or thread local states in FunctionContext to nullptr after freeing them in various built-in's Close() functions. Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c Reviewed-on: http://gerrit.cloudera.org:8080/6757 Reviewed-by: Dan Hecht <[email protected]> Reviewed-by: Attila Jeges <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/exprs/case-expr.cc M be/src/exprs/hive-udf-call.cc M be/src/exprs/in-predicate.h M be/src/exprs/like-predicate.cc M be/src/exprs/math-functions-ir.cc M be/src/exprs/string-functions-ir.cc M be/src/exprs/timestamp-functions.cc M be/src/exprs/udf-builtins-ir.cc M be/src/exprs/utility-functions.cc M be/src/testutil/test-udfs.cc M be/src/udf/udf-test.cc 11 files changed, 28 insertions(+), 20 deletions(-) Approvals: Impala Public Jenkins: Verified Attila Jeges: Looks good to me, but someone else must approve Dan Hecht: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2c689246ed4f8dd38f104fa35904f3926a7039c Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
