Anything else you would like me to change for a +1? Alex, Marcel, do you prefer to have a look before or after rebasing the change?
Cheers, Lars On Sun, May 7, 2017 at 4:57 AM, Dimitris Tsirogiannis < [email protected]> wrote: > For consistency, I believe we should at least allow an empty SORT BY() > clause in the CREATE TABLE statement, but I'll defer the decision to Alex > or Marcel. > > Dimitris > > On Sat, May 6, 2017 at 8:16 AM, Lars Volker (Code Review) < > [email protected]> wrote: > >> Lars Volker has posted comments on this change. >> >> Change subject: IMPALA-4166: Add SORT BY sql clause >> ...................................................................... >> >> >> Patch Set 20: >> >> > There is still one thing that is not clear to me. Why is it allowed >> > to do an ALTER TABLE with an empty SORT BY clause but not a CREATE >> > TABLE? >> >> The easiest way to specify an empty list of sort by columns during CREATE >> TABLE is to omit the SORT BY clause altogether. To keep things simple I did >> not add additional support for an empty SORT BY () clause. >> >> For ALTER TABLE there needs to be a way to specify an empty list of >> columns, but since SORT BY is used to identify the command, the most simple >> form seemed to be an empty column list(). >> >> Do you think we should allow CREATE TABLE SORT BY() in addition to >> specify an empty set of column? >> >> -- >> To view, visit http://gerrit.cloudera.org:8080/6495 >> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings >> >> Gerrit-MessageType: comment >> Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75 >> Gerrit-PatchSet: 20 >> Gerrit-Project: Impala-ASF >> Gerrit-Branch: master >> Gerrit-Owner: Lars Volker <[email protected]> >> Gerrit-Reviewer: Alex Behm <[email protected]> >> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> >> Gerrit-Reviewer: Lars Volker <[email protected]> >> Gerrit-Reviewer: Marcel Kornacker <[email protected]> >> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> >> Gerrit-HasComments: No >> > >
