Tim Armstrong has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5715/7/be/src/kudu/util/compression/compression_codec.cc File be/src/kudu/util/compression/compression_codec.cc: Line 28: #ifdef DISALLOW_COPY_AND_ASSIGN Maybe comment that snappy.h redefines this so that we don't lose track of why this is here. http://gerrit.cloudera.org:8080/#/c/5715/7/be/src/kudu/util/status.h File be/src/kudu/util/status.h: Line 122: #ifndef KUDU_LOG Is this still needed? I don't see how this can get defined twice. -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8da798ee55506d6f969416b17c191eb03cb215f5 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
