Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5137: Support Kudu UNIXTIME_MICROS as Impala TIMESTAMP ......................................................................
Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/6526/7/be/src/exec/kudu-util.h File be/src/exec/kudu-util.h: Line 89: if (COPY_STRINGS) { it doesn't feel like this particular if should be very performance-relevant. let's make it a standard function again, with an extra bool param. http://gerrit.cloudera.org:8080/#/c/6526/7/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: Line 1: // Licensed to the Apache Software Foundation (ASF) under one this file is included in bunch of .h files. now that you pulled out a bunch of function bodies, those includes may not be necessary anymore. (i see one in util/promise.h, for instance). would be nice to clean that up as well. doesn't have to be as part of this change, but it's good to do some housecleaning as you go. -- To view, visit http://gerrit.cloudera.org:8080/6526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae6ccfffb79118a9036fb2227dba3a55356c896d Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
