Marcel Kornacker has posted comments on this change. Change subject: IMPALA-5294: Kudu INSERT partitioning fails with constants ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6828/1/fe/src/main/java/org/apache/impala/analysis/KuduPartitionExpr.java File fe/src/main/java/org/apache/impala/analysis/KuduPartitionExpr.java: Line 58: partitionKeyTypes_.add(e.getType()); why can this not be derived from the target table? http://gerrit.cloudera.org:8080/#/c/6828/1/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: Line 251: Lists.newArrayList(insertStmt.getPartitionKeyExprs()), i don't like this solution, because that ignores whatever else might have been done to partitionExprs. since these are constants, why can't KuduPartitionExpr add random constants itself? the fact that kudupartitionexpr needs a certain number of exprs shouldn't have to creep into distributedplanner. -- To view, visit http://gerrit.cloudera.org:8080/6828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12cbb319f9a5c47fdbfee347b47650186b27f8f9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
