Attila Jeges has posted comments on this change. Change subject: IMPALA-5137: pt1, Refactor TimestampValue constructors ......................................................................
Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/6510/11/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS11, Line 282: nit: indentation is 4 for line continuation (here and below). http://gerrit.cloudera.org:8080/#/c/6510/11/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: PS11, Line 93: TimestampValue t You might want to use "const TimestampValue& t =" here (and below), just like you did in aggregate-functions-ir.cc -- To view, visit http://gerrit.cloudera.org:8080/6510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id25e19f7984e5ebf9073d9c569faf69cec142fa1 Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
