Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5297: Reduce free-pool-test mem requirement to avoid OOM ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6842/1/be/src/runtime/free-pool-test.cc File be/src/runtime/free-pool-test.cc: PS1, Line 132: 1LL > Will 2LL be too much ? I was hoping we could exercise the code for 64-bit a we can keep this as is PS1, Line 138: memset(p1, 1, size); > Should be sufficient to replace it with *p1 = 1; Good idea, this works well -- To view, visit http://gerrit.cloudera.org:8080/6842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31f03e7a4d5d237a1183277c988f85a992396a43 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
