Lars Volker has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause ......................................................................
Patch Set 22: (3 comments) Thanks for the review. I'm working on the comments, but in the meantime wanted to check whether we should uniformly rename all occurrences of "sort.?by.?columns" to sort_columns or sorting_columns. http://gerrit.cloudera.org:8080/#/c/6495/22/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: Line 382: // Optional list of sort by columns for the new table. If specified, these will override > "sort columns" or "sorting columns" (as in: partition columns) Done. There's a lot of other places in the code where that term is used, including the table property, which is called 'sort.by.columns'. Should I replace them all? Line 385: 9: optional list<string> sort_by_columns > sort_columns Done Line 439: 16: optional list<string> sort_by_columns > same Done -- To view, visit http://gerrit.cloudera.org:8080/6495 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08834f38a941786ab45a4381c2732d929a934f75 Gerrit-PatchSet: 22 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
