Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5137: Support pushing TIMESTAMP predicates to Kudu ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6789/3/fe/src/main/java/org/apache/impala/util/KuduUtil.java File fe/src/main/java/org/apache/impala/util/KuduUtil.java: Line 206: toUnixTimeExpr.analyze(analyzer); > you could also use a local analyzer (meaning new analyzer) here, no? that w I don't follow. If I create new Analyzer in this function, that would still need to take a catalog and queryCtx as parameters, so wouldn't I need to pass those as parameters? If that's the case that wouldn't save me a parameter to this function, if that's what you're suggesting. I also need the query ctx when calling EvalExprWithoutRow. -- To view, visit http://gerrit.cloudera.org:8080/6789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08b6c8354a408e7beb94c1a135c23722977246ea Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
