Tim Armstrong has posted comments on this change. Change subject: IMPALA-5304: reduce transfer of Parquet decompression buffers ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6876/2/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: Line 1037: decompressed_data_pool_->FreeAll(); > Makes sense. We could selectively Clear() and FreeAll() depending on the un I'd prefer to defer it - I think a policy like that would be better implemented within Clear() since it's generally applicable. http://gerrit.cloudera.org:8080/#/c/6876/2/be/src/exec/parquet-column-readers.h File be/src/exec/parquet-column-readers.h: Line 476: && slot_desc_ != nullptr && slot_desc_->type().IsVarLenType(); > I think checking IsStringType() is more accurate because IsVarLenType() inc You're right, CHAR columns could reference the pages directly in some cases. -- To view, visit http://gerrit.cloudera.org:8080/6876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dbd749f43078b222ff8e1ddcec840986c466de6 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
