Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext ......................................................................
Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/5483/13/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: PS13, Line 1104: const vector<FilterContext>& filter_ctxs Should avoid using FilterContext for codegen as it's runtime state. http://gerrit.cloudera.org:8080/#/c/5483/13/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: PS13, Line 366: expr_mem_pool() not thread safe to use expr_mem_pool(). -- To view, visit http://gerrit.cloudera.org:8080/5483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefdc9aeeba033355cb9497e3a5d2363627dcf2f3 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
