Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5340: Query profile displays stale query state ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6923/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: Line 725: summary_profile_.AddInfoString("Query State", PrintQueryState(query_state_)); it's a shame to have to duplicate this everywhere, seems error prone to have to remember to set the query_state_ and also set the summary_profile_ property. Can you make a little private fn which sets the query state and profile at the same time? Also make sure the comment in the header states that if query_state_ is set, the profile must be updated - your fn should be used to do so. -- To view, visit http://gerrit.cloudera.org:8080/6923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I952319b7308a24d4e2dff924199c0c771bce25b3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
