Alex Behm has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS <db> statement ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6878/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: PS2, Line 639: > Done. I thought that was the idea, to throw the exception and catch it belo Oh I see. Got it, my bad. Please revert, the new code has a bug (never releases lock when DatabaseNotFoundException is thrown). http://gerrit.cloudera.org:8080/#/c/6878/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: Line 420: throw new DatabaseNotFoundException(Analyzer.DB_DOES_NOT_EXIST_ERROR_MSG + dbName); Please revert. We try to separate catalog and analysis code as much as possible. Referencing the analyzer in a catalog object breaks that. Line 638: throw new DatabaseNotFoundException(Analyzer.DB_DOES_NOT_EXIST_ERROR_MSG + dbName); please revert this error msg -- To view, visit http://gerrit.cloudera.org:8080/6878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3625c88bb51cca833f3293c224d3f0feb00e6e0b Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
