Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6921 to look at the new patch set (#3). Change subject: IMPALA-5339: Fix analysis with sort.columns and expr rewrites ...................................................................... IMPALA-5339: Fix analysis with sort.columns and expr rewrites IMPALA-4166 introduced a bug by duplicating code that adds sort expressions. Upon re-analysis, this code would hit an IndexOutOfBoundsException. Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a --- M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/TableDef.java M testdata/workloads/functional-planner/queries/PlannerTest/insert-sort-by.test 4 files changed, 82 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/6921/3 -- To view, visit http://gerrit.cloudera.org:8080/6921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibebba29509ae7eaa691fe305500cda6bd41a179a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>