Dan Hecht has posted comments on this change. Change subject: Revert "IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet" ......................................................................
Patch Set 1: Code-Review+2 (3 comments) I only looked at the files with conflicts. http://gerrit.cloudera.org:8080/#/c/6896/1/be/src/runtime/timestamp-value.cc File be/src/runtime/timestamp-value.cc: Line 95: return; your changes here seemed like an improvement. consider bringing them back in another change (but doesn't have to be part of this revert). http://gerrit.cloudera.org:8080/#/c/6896/1/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: Line 25: #include <boost/date_time/posix_time/posix_time_types.hpp> why do we need these headers? http://gerrit.cloudera.org:8080/#/c/6896/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: Line 123: private final static long MIN_SYNTHETIC_BLOCK_SIZE = 1024 * 1024; what did these have to do with your change? are they just dead variables (in which case it'd be nice to re-apply this later)? -- To view, visit http://gerrit.cloudera.org:8080/6896 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic66de277c622748540c1b9969152c2cabed1f3bd Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
