Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1972/IMPALA-3882: Fix client_request_state_map_lock_ contention ......................................................................
Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/6707/9/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 607: if (request_state->query_state() == beeswax::QueryState::CREATED) { > as we discussed in person, here we'll return something like the caller does Done Line 607: if (request_state->query_state() == beeswax::QueryState::CREATED) { > Additionally, let's exercise this case in the new test. Done http://gerrit.cloudera.org:8080/#/c/6707/9/tests/custom_cluster/test_query_concurrency.py File tests/custom_cluster/test_query_concurrency.py: PS9, Line 75: 30000 > that doesn't seem large enough. check_registered_queries() is allowed to wa I don't think it waits 15s everytime. It waits for 15s overall. So it still returns before pause_injection time is hit (30s). Not sure I follow you. Did it fail for you locally? In any case, I made the pause 100s, we don't wait on it anyway. -- To view, visit http://gerrit.cloudera.org:8080/6707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie44daa93e3ae4d04d091261f3ec4891caffe8026 Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
