Np, Thought it would be good to get this in asap :) On Tue, May 23, 2017 at 9:56 AM, Sailesh Mukil <[email protected]> wrote:
> Thanks for merging it, Alex. I forgot to re +2 it after rebasing. > > On Tue, May 23, 2017 at 9:42 AM, Alex Behm (Code Review) < > [email protected]> wrote: > >> Alex Behm has submitted this change and it was merged. >> >> Change subject: IMPALA-5331: Use new libHDFS API to address "Unknown >> Error 255" >> ...................................................................... >> >> >> IMPALA-5331: Use new libHDFS API to address "Unknown Error 255" >> >> We use the new libHDFS API hdfsGetLastExceptionRootCause() to return >> the last seen HDFS error on that thread. >> >> This patch depends on the recent HDFS commit: >> https://github.com/apache/hadoop/commit/fda86ef2a32026c02d9b >> 5d4cca1ecb7b4decd872 >> >> Testing: A test has been added which puts HDFS in safe mode and then >> verifies that we see a 255 error with the root cause. >> >> Change-Id: I181e316ed63b70b94d4f7a7557d398a931bb171d >> Reviewed-on: http://gerrit.cloudera.org:8080/6894 >> Tested-by: Impala Public Jenkins >> Reviewed-by: Alex Behm <[email protected]> >> --- >> M be/src/util/hdfs-bulk-ops.cc >> M be/src/util/hdfs-util.cc >> M tests/data_errors/test_data_errors.py >> 3 files changed, 44 insertions(+), 1 deletion(-) >> >> Approvals: >> Impala Public Jenkins: Verified >> Alex Behm: Looks good to me, approved >> >> >> >> -- >> To view, visit http://gerrit.cloudera.org:8080/6894 >> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings >> >> Gerrit-MessageType: merged >> Gerrit-Change-Id: I181e316ed63b70b94d4f7a7557d398a931bb171d >> Gerrit-PatchSet: 9 >> Gerrit-Project: Impala-ASF >> Gerrit-Branch: master >> Gerrit-Owner: Sailesh Mukil <[email protected]> >> Gerrit-Reviewer: Alex Behm <[email protected]> >> Gerrit-Reviewer: Dan Hecht <[email protected]> >> Gerrit-Reviewer: David Knupp <[email protected]> >> Gerrit-Reviewer: Henry Robinson <[email protected]> >> Gerrit-Reviewer: Impala Public Jenkins >> Gerrit-Reviewer: Matthew Jacobs <[email protected]> >> Gerrit-Reviewer: Sailesh Mukil <[email protected]> >> > >
