Henry Robinson has posted comments on this change. Change subject: IMPALA-4890/5143: Coordinator race involving TearDown() ......................................................................
Patch Set 1: (2 comments) Where does ReleaseResources() get called for DML queries? It used to be in ClientRequestState::Done(), I think, but I don't see where it gets called now (it must be, because tests are passing). http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS1, Line 113: if (query_state_ != nullptr) { : ExecEnv::GetInstance()->query_exec_mgr()->ReleaseQueryState(query_state_); : } I thought that in general we wanted to move away from work done in d'tors? http://gerrit.cloudera.org:8080/#/c/6897/1/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: PS1, Line 79: eos this doesn't include the DML case, where query completion is signalled by the query returning from Wait() I think. -- To view, visit http://gerrit.cloudera.org:8080/6897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I457a6424a0255c137336c4bc01a6e7ed830d18c7 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
