Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5259: Add REFRESH FUNCTIONS <db> statement ......................................................................
Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/6878/9/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: PS9, Line 631: } catch (Exception e) { : throw new CatalogException("Error refreshing functions in " + dbName + ": ", e); : } You have two try-catch blocks with the same Exception type and the same action. Merge them? PS9, Line 648: fn.setCatalogVersion(incrementAndGetCatalogVersion()); Is this needed? PS9, Line 662: // We do not need to increment and acquire a new catalog version for this : // function here because this already happens when the functions are loaded : // into tmpDb. nit: move comment above L660. http://gerrit.cloudera.org:8080/#/c/6878/9/fe/src/main/java/org/apache/impala/catalog/Db.java File fe/src/main/java/org/apache/impala/catalog/Db.java: PS9, Line 368: /** : * Remove all functions. : */ remove -- To view, visit http://gerrit.cloudera.org:8080/6878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3625c88bb51cca833f3293c224d3f0feb00e6e0b Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
