Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. ......................................................................
Patch Set 3: So I simplified this by representing it as a CHANGE operation in the catalog. I think that it would be easy to go one step further and eliminate 'class AlterColumnStmt' and fold the functionality into 'class AlterTableChangeColStmt', but this would have the side effect of allowing changing these options through a CHANGE statement, and it might be confusing to have two ways of doing the same thing. Thoughts? Also, do we want to support 'SET default NULL'? Kudu explicitly disallows this and requires that you use 'dropDefault'. The patch currently allows it and then converts it to a drop before sending it to Kudu, but we might want to disallow it as well. -- To view, visit http://gerrit.cloudera.org:8080/6955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2e8bd65342b79644a0fdcd925e6f17797e89ad6 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: No
