Matthew Jacobs has posted comments on this change. Change subject: Ported native-toolchain to work on ppc64le ......................................................................
Patch Set 5: (3 comments) looking much better, thank you Valencia! http://gerrit.cloudera.org:8080/#/c/6468/5/buildall.sh File buildall.sh: PS5, Line 101: if (( BUILD_HISTORICAL )) ; then : CRCUTIL_VERSION=440ba7babeff77ffad992df3a10c767f184e946e\ : $SOURCE_DIR/source/crcutil/build.sh : fi we stopped doing the BUILD_HISTORICAL thing, you can remove this unless we need both versions, but if that's the case then it shouldn't be conditional anyway. http://gerrit.cloudera.org:8080/#/c/6468/5/source/breakpad/breakpad-ffe3e478657dc7126fca6329dfcedc49f4c726d9-patches/0002-Build-breakpad-ffe3e47-on-ppc64le.patch File source/breakpad/breakpad-ffe3e478657dc7126fca6329dfcedc49f4c726d9-patches/0002-Build-breakpad-ffe3e47-on-ppc64le.patch: Line 1: Only in breakpad-88e-p3/: my_breakpad there should be no changes to the x86 binary, right? would it be possible to verify that? http://gerrit.cloudera.org:8080/#/c/6468/5/source/crcutil/crcutil-440ba7babeff77ffad992df3a10c767f184e946e-patches/0001-Build-crcutil-440ba7b-on-ppc64le.patch File source/crcutil/crcutil-440ba7babeff77ffad992df3a10c767f184e946e-patches/0001-Build-crcutil-440ba7b-on-ppc64le.patch: Line 1: diff -urx '*.m4' crcutil-440ba7babeff77ffad992df3a10c767f184e946e_up/autogen.sh crcutil-440ba7babeff77ffad992df3a10c767f184e946e/autogen.sh same thing about not affecting the x86 binary? -- To view, visit http://gerrit.cloudera.org:8080/6468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7931752ca497bc7a5e3cc574bbb54637f382c72a Gerrit-PatchSet: 5 Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-Owner: Valencia Edna Serrao <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Valencia Edna Serrao <[email protected]> Gerrit-HasComments: Yes
