Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2373: Extrapolate row counts for HDFS tables. ......................................................................
Patch Set 8: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/6840/6//COMMIT_MSG Commit Message: PS6, Line 30: run http://gerrit.cloudera.org:8080/#/c/6840/6/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: PS6, Line 304: else { : tableStats_ = new TTableStats(-1); : tableStats_.setTotal_file_bytes(-1); : } Do you need this? http://gerrit.cloudera.org:8080/#/c/6840/6/fe/src/main/java/org/apache/impala/catalog/View.java File fe/src/main/java/org/apache/impala/catalog/View.java: PS6, Line 118: tableStats_ = new TTableStats(-1); : tableStats_.setTotal_file_bytes(-1); Didn't you remove this? Maybe I am confused. http://gerrit.cloudera.org:8080/#/c/6840/8/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: PS8, Line 724: post-sampling bytes What is the "post-sampling bytes"? -- To view, visit http://gerrit.cloudera.org:8080/6840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I972c8a03ed70211734631a7dc9085cb33622ebc4 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-HasComments: Yes
