Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5232: Parquet reader error message prints memory address instead of value ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6982/2//COMMIT_MSG Commit Message: PS2, Line 8: instead of value Nit: The title can exceed 70 chars. We want the title to be on one line so we can see it in the single line commit list on github. I should have mentioned that earlier. Line 16: - num_bytes = *data_size + 1 It'll also be good to mention why you're not adding automated tests. -- To view, visit http://gerrit.cloudera.org:8080/6982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a8f424807877c38d6f113db924cec8c68828c70 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
