Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5338: Fix Kudu timestamp column default values ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6936/1/fe/src/main/java/org/apache/impala/analysis/ColumnDef.java File fe/src/main/java/org/apache/impala/analysis/ColumnDef.java: Line 87: // post-analysis. For TIMESTAMPs those are Kudu UNIXTIME_MICROS, i.e. int64s. > i don't like that this changes its meaning as a result of analysis, because Done http://gerrit.cloudera.org:8080/#/c/6936/1/fe/src/main/java/org/apache/impala/util/KuduUtil.java File fe/src/main/java/org/apache/impala/util/KuduUtil.java: Line 167: public static Object getKuduDefaultValue(TExpr defaultValue, > supply function comment Done http://gerrit.cloudera.org:8080/#/c/6936/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: Line 2403: "ts timestamp not null default cast('2009-01-01 00:00:00' as timestamp)) " + > should we also allow a string constant here (that we then try to convert to Sure I can do that -- To view, visit http://gerrit.cloudera.org:8080/6936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I655910fb4805bb204a999627fa9f68e43ea8aaf2 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
