Alex Behm has posted comments on this change. Change subject: IMPALA-5358: Fix repeatable table sample. ......................................................................
Patch Set 1: Thanks, Henry. Can you clarify what you mean by REPEAT() clause? Did you mean REPEATABLE? That clause is mandatory for most tests and the PlannerTest that failed did have a test. The underlying issue is that we store the partitions as a Map<id, HdfsPartition> so iterating over the map can give us the partitions in an arbitrary order. I'll keep thinking whether we can have a more direct test, but luckiy our tests did ultimately catch this issue :) -- To view, visit http://gerrit.cloudera.org:8080/6985 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9110751b075430b068b52d7441e5845f86d1b6af Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-HasComments: No
