Michael Brown has posted comments on this change. Change subject: Loads all TPC-DS tables ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/6877/7//COMMIT_MSG Commit Message: PS7, Line 7: Loads all TPC-DS tables Jira? PS7, Line 21: before. The results of E2E tests were compared against the run done with : Netezza and Vertica. Thanks for saying so! http://gerrit.cloudera.org:8080/#/c/6877/7/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: PS7, Line 365: impala_home = os.getenv("IMPALA_HOME"), : hint = insert_hint) Please remove spaces around = as above. http://gerrit.cloudera.org:8080/#/c/6877/7/testdata/datasets/tpcds/tpcds_schema_template.sql File testdata/datasets/tpcds/tpcds_schema_template.sql: PS7, Line 27: cc_rec_start_date string : cc_rec_end_date string Here and likely elsewhere, there are column type differences between the spec and here, and here is one of those places.. Is there a general motivation for having different types here differ with those in the spec? For example, why not timestamp? -- To view, visit http://gerrit.cloudera.org:8080/6877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5277245fd20827c9c09ce5c1a7a37266ca476b9 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-HasComments: Yes
