Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6991/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 279: void TestLastDayFunction() { > MariaDB returns only the DATE portion of the timestamp. That would be neat I didn't mean in automated tests but rather checking by manual inspection, sorry if it's a pain but we should just check. http://gerrit.cloudera.org:8080/#/c/6991/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 285: TestTimestampValue("last_day('2003-03-02 03:21:12')", add some fractional seconds too http://gerrit.cloudera.org:8080/#/c/6991/3/be/src/exprs/timestamp-functions.h File be/src/exprs/timestamp-functions.h: PS3, Line 199: DATE or Impala doesn't have a DATE type so this is misleading. I think you can say "The input timestamp requires a date component, it may or may not have a time component." Comment when this returns a TimestampVal set to null. -- To view, visit http://gerrit.cloudera.org:8080/6991 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I429c8734bddca3c37a2eedc211a16a4ffcb04370 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-HasComments: Yes
