Zach Amsden has posted comments on this change. Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries ......................................................................
Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/6726/10/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 167: static const int MAX_BATCH_SIZE = 65536; Didn't end up needing this. http://gerrit.cloudera.org:8080/#/c/6726/10/be/src/util/bitmap.h File be/src/util/bitmap.h: Line 79: /// Returns next set bit, or num_bits_ if the end is reached. This function ended up unused as well. What shall we do with it? http://gerrit.cloudera.org:8080/#/c/6726/10/testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test File testdata/workloads/functional-planner/queries/PlannerTest/parquet-filtering.test: Line 25: parquet dictionary predicates: int_col IS NULL, int_col > 1 Bogus test change needs to be backed out. -- To view, visit http://gerrit.cloudera.org:8080/6726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65981c89e5292086809ec1268f5a273f4c1fe054 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
