Tim Wood has posted comments on this change.

Change subject: IMPALA-4988: Add query option read_parquet_statistics
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7001/1/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

What kind of controls do we have to help ensure that files like query-options.h 
and query-options.cc stay in sync with this file?


http://gerrit.cloudera.org:8080/#/c/7001/1/testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test
File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test:

Line 455: ---- RESULTS
How about a test for 
set read_parquet_statistics=false
?


-- 
To view, visit http://gerrit.cloudera.org:8080/7001
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I427f7fde40d0f4b703751e40f3c2109a850643f7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Tim Wood <[email protected]>
Gerrit-HasComments: Yes

Reply via email to